The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: jarekmorawski <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: talldan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Looks like some Playwright tests are failing, will be adding a commit to fix the failing test cases.

Took the latest iteration for a spin. This feel very solid for me:

I'd encourage others to give this a spin, to check compatibility across platforms, etc, but this PR feels more intuitive than trunk, for the moment. Thank you!

On Windows, the shortcut looks like this:

One thing I noticed is that depending on the cursor position, the process to merge blocks can be prioritized. Below are two scenarios:

• Execute ctrl+shift+backspaceat the beginning of the text
• Execute ctrl+shift+del at the end of the text

Can these be reproduced on a Mac? If the backspace and del keys don't work consistently, we might want to consider the d key.

Can these be reproduced on a Mac?

Yes, @t-hamano, you are right about that. And it's the same for Mac. I believed it was intended and that backspace and del should be aliased together. However, it's to be noted that the majority of the users would intuitively understand this behavior, and backspace and del are very intuitive ways of making a deletion. So, general users might just prefer it.

we might want to consider the d key.

ctrl+alt+d and ctrl+shift+alt+d seem to be the only shortcuts available with d. The second one is too big, leaving just ctrl+alt+d behind.

What are your thoughts on this? Do we proceed with implementing ctrl+alt+d?

Mac OS: cmd + option + d
Windows: ctrl + alt + d

Does this sound good?

I came up with a different solution: merging blocks using del or Backspace is done here, so when command/ctrl + shift + del/backspace is executed, aborts the process:

diff --git a/packages/block-editor/src/components/rich-text/event-listeners/delete.js b/packages/block-editor/src/components/rich-text/event-listeners/delete.js
index ae3fd733bb..12512626d9 100644
--- a/packages/block-editor/src/components/rich-text/event-listeners/delete.js
+++ b/packages/block-editor/src/components/rich-text/event-listeners/delete.js
@@ -6,7 +6,7 @@ import { isCollapsed, isEmpty } from '@wordpress/rich-text';
 
 export default ( props ) => ( element ) => {
        function onKeyDown( event ) {
-               const { keyCode } = event;
+               const { keyCode, ctrlKey, shiftKey } = event;
 
                if ( event.defaultPrevented ) {
                        return;
@@ -30,6 +30,11 @@ export default ( props ) => ( element ) => {
                                return;
                        }
 
+                       // Exclude command+shift+del/delete as they are shortcuts for deleting blocks.
+                       if ( event.ctrlKey && event.shiftKey ) {
+                               return;
+                       }
+
                        if ( onMerge ) {
                                onMerge( ! isReverse );
                        }

Hi @t-hamano, thanks for suggesting this approach. I've incorporated it in the latest commit. Also, as per this comment, I've implemented shift+backspace as the standard shortcut for deleting the blocks.

I've updated the PR Title, Description, and Screencasts/ Screenshots used appropriately to reflect the same.

Thank you, @t-hamano and @jasmussen, for taking the time to test the PR ✨!